Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect semaphore init could cause msm deadlock #411

Merged
merged 1 commit into from Jun 15, 2023
Merged

fix: incorrect semaphore init could cause msm deadlock #411

merged 1 commit into from Jun 15, 2023

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Jun 14, 2023

No description provided.

@gbotrel gbotrel requested review from ivokub and yelhousni June 14, 2023 21:45
ivokub
ivokub approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also tested PR with previously failing edge case and it is now fixed.

@gbotrel gbotrel merged commit a3b568a into develop Jun 15, 2023
6 checks passed
@gbotrel gbotrel deleted the fix/msmdeadlock branch June 15, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

@yelhousni yelhousni Awaiting requested review from yelhousni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gbotrel @ivokub