Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarks for
Neg(...)
of points in Edwards variants, and an optimization to avoid redundant assignment in point coordinates.If we run the new benchmarks available in the second commit of this branch against the same ones after the optimization here's what we get:
The TL;DR is quite simple: a
.Set(...)
call will copy coordinates that need to be negated afterward, so that's unnecessary work.I double-checked, and this optimization looks to be already present for the base curves, so it was only missing for edwards variants.