fix: fixes #918 incorrect hash Sum usage

Consensys · Nov 16, 2023 · d7ce488 · d7ce488
1 parent 31800ee
commit d7ce488
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 16 deletions.
diff --git a/backend/plonk/bls12-377/verify.go b/backend/plonk/bls12-377/verify.go
diff --git a/backend/plonk/bls12-381/verify.go b/backend/plonk/bls12-381/verify.go
diff --git a/backend/plonk/bls24-315/verify.go b/backend/plonk/bls24-315/verify.go
diff --git a/backend/plonk/bls24-317/verify.go b/backend/plonk/bls24-317/verify.go
diff --git a/backend/plonk/bn254/verify.go b/backend/plonk/bn254/verify.go
diff --git a/backend/plonk/bw6-633/verify.go b/backend/plonk/bw6-633/verify.go
diff --git a/backend/plonk/bw6-761/verify.go b/backend/plonk/bw6-761/verify.go
diff --git a/internal/generator/backend/template/zkpschemes/plonk/plonk.verify.go.tmpl b/internal/generator/backend/template/zkpschemes/plonk/plonk.verify.go.tmpl
@@ -111,15 +111,14 @@ func Verify(proof *Proof, vk *VerifyingKey, publicWitness fr.Vector, opts ...bac
 		if cfg.HashToFieldFn == nil {
 			cfg.HashToFieldFn = hash_to_field.New([]byte("BSB22-Plonk"))
 		}
-		var hashBts []byte
 		var hashedCmt fr.Element
 		nbBuf := fr.Bytes
 		if cfg.HashToFieldFn.Size() < fr.Bytes {
 			nbBuf = cfg.HashToFieldFn.Size()
 		}
 		for i := range vk.CommitmentConstraintIndexes {
 			cfg.HashToFieldFn.Write(proof.Bsb22Commitments[i].Marshal())
-			hashBts = cfg.HashToFieldFn.Sum(hashBts[0:])
+			hashBts := cfg.HashToFieldFn.Sum(nil)
 			cfg.HashToFieldFn.Reset()
 			hashedCmt.SetBytes(hashBts[:nbBuf])