Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac/compress packing #1007

Merged
merged 29 commits into from Jan 21, 2024
Merged

Refac/compress packing #1007

merged 29 commits into from Jan 21, 2024

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Jan 18, 2024

Major change: The Decompressor gadget takes in bytes rather than words
Minor change: Many helper functions for integration

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Old tests and new

How has this been benchmarked?

Not benchmarked. E2E benchmark coming in the zkevm monorepo

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tabaie Tabaie requested a review from gbotrel January 18, 2024 10:07
frontend/cs/scs/api.go Outdated Show resolved Hide resolved
frontend/api.go Show resolved Hide resolved
std/compress/internal/plonk_helpers/plonk_helpers.go Outdated Show resolved Hide resolved
std/compress/internal/io.go Show resolved Hide resolved
std/compress/internal/io.go Show resolved Hide resolved
std/compress/lzss/snark.go Outdated Show resolved Hide resolved
std/compress/lzss/snark_testing.go Outdated Show resolved Hide resolved
std/compress/lzss/e2e_test.go Outdated Show resolved Hide resolved
std/compress/io.go Show resolved Hide resolved
std/compress/io.go Show resolved Hide resolved
@Tabaie Tabaie requested a review from gbotrel January 19, 2024 21:39
@Tabaie Tabaie merged commit 7d13fdf into master Jan 21, 2024
7 checks passed
@Tabaie Tabaie deleted the refac/compress-packing branch January 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants