Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename ScalarMultiplication -> ScalarMul #342

Closed
wants to merge 1 commit into from

Conversation

yelhousni
Copy link
Contributor

Rename ScalarMultiplication() to ScalarMul(). Needs Consensys/gnark-crypto#220 PR to be merged first.

@yelhousni
Copy link
Contributor Author

In Groth16 the prover computes 3 ScalarMul() with random scalars r and s (2 G1, 1 G2). These call the internal mulGLV() which first split the random r and s into sub-scalars before hitting the for loop. I tried to remove the SplitScalar() from the mulGLV() and put it explicitly in ScalarMul(). This way one can sample directly random sub-scalars and use MulGLV() instead of ScalarMul(). However it's just a -1% after PR Consensys/gnark-crypto#213 which speeds up the scalar decomposition.

@gbotrel
Copy link
Collaborator

gbotrel commented Jul 27, 2022

Let's discuss here: Consensys/gnark-crypto#224

@yelhousni
Copy link
Contributor Author

closing this after Consensys/gnark-crypto#224

@yelhousni yelhousni closed this Jul 27, 2022
@gbotrel gbotrel deleted the refactor/ScalarMul branch August 21, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants