Optimize bn254/groth16 solidity verifier. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix misspelled ("decsribes" -> "describes")
* fix misspelled ("decsribes" -> "describes") from tmpl file and regenerate
Co-authored-by: tinywell <tinywell@tinywell.com>
Fix: minor typo
gbotrel
reviewed
Oct 6, 2022
| add_input[3] = uint256({{$ki.Y.String}}); | ||
| Pairing.plus_raw(add_input, add_return); | ||
| {{- end -}} | ||
| {{- end }} |
There was a problem hiding this comment.
test were failing because; vk_x is used in the pairing computation, while the result from add_return is not.
Will merge and do the quick fix on develop
AlexandreBelling
pushed a commit
to AlexandreBelling/gnark
that referenced
this pull request
Nov 24, 2022
* fix: misspelled ("decsribes" -> "describes") (Consensys#339)
* fix misspelled ("decsribes" -> "describes")
* fix misspelled ("decsribes" -> "describes") from tmpl file and regenerate
Co-authored-by: tinywell <tinywell@tinywell.com>
* Fix: minor typo (Consensys#360)
Fix: minor typo
* Use shared array for input
* Fixes in the template
Co-authored-by: tinywell <zfh-zyw@163.com>
Co-authored-by: tinywell <tinywell@tinywell.com>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Existing implementation of Pairing library allocated additional memory on each addition and multiplication, which can quadratically increase gas cost with larger public input.
This PR addresses several things:
inputfrommemorytocalldata. Ideally public input should be constructed off-chain and remain only in call data. It is important to notice, that caller smart contract might already do it, but EVM implicitly copy call data to memory, which is not needed in this case.