refactor: emulated clean up fixes #448 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gbotrel
commented
Jan 26, 2023
gbotrel
commented
- refactor: step 1 clean up api and builder wrapper
- refactor: PackElementLimbs PackFull -> packLimbs
- refactor: added field.NewElement
- refactor: remove deadcode from builder stuff, update stats with constraining inputs
ivokub
requested changes
Jan 27, 2023
There was a problem hiding this comment.
In general looks good. I think we do not need GnarkInitHook anymore though?
And now there is only a single use of Field.NewElement. In some tests we use emulated.ValueOf where we actually initialise constant in-circuit and then it would be better to use Field.NewElement to set internal=true
ivokub
reviewed
Jan 27, 2023
ivokub
reviewed
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.