refactor: plonk uses constraint/ and couple of fixes closes #467 #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of @ivokub #481 and #483 .
frontend/cs/scs
now usesconstraint/
package (killedTermToRefactor
andLinearExpressionToRefactor
) .builder.addPlonkConstraint(...)
signature changed;introduced
and ensured all apis use this format clearly (doc + call).
Perf improvement:
api.Add(v1, v2, constant, v3, ...)
; the constant part is now "merged" into one of the sub-constraints (for exampleAssertIsLessOrEqual
benefits from that).Fixes
api.Xor
api.Or
andapi.IsZero
that would assume the coeff a variable that is boolean is always 1. (whereas we should check coeff*wire == 0|1).