refactor: use emulated.FieldParams as type parameter to generic Curve and Pairing #901

ivokub · 2023-11-03T12:51:15Z

Description

For the PLONK and KZG verifiers we need to work on the scalar fields. However, in the existing parametrization we didn't have access to the field parameters and the 2-chain scalars weren't compatible.

This PR makes the generic Curve and Pairing interfaces parametric with emulated.FieldParams which defines the scalar field. Accordingly, we update all the implementations to follow the convention. As now the scalars are emulated elements, then we also defined 2-chain scalars to be emulated elements which is more conventional.

NB! This PR depends on #900 so that should be merged before.

Type of change

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

All existing tests pass as is.

How has this been benchmarked?

Not benchmarked.

Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I did not modify files generated from templates
golangci-lint does not output errors locally
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

ivokub · 2023-11-06T15:00:33Z

Also @yelhousni - this also impact KZG verifier.

github-actions · 2023-11-07T11:28:13Z

📦 github.com/consensys/gnark/std/algebra/native/sw_bls12377
❌ TestMarshalScalar 0s

❌ TestMarshalScalar/bw6_761 0s

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 0 == 1
        	            	sw_bls12377.(*MarshalScalarTest).Define
        	            		g1_test.go:47
        	            	
        	            	witness:{"X":{"Limbs":["8156853329741982713","3068138849464570087","15990919781714332387","1157640988544703959"]},"R":[0,0,0,1,0,0,0,0,0,0,0,1,0,0,0,0,1,1,0,0,0,1,0,0,0,1,0,1,1,0,0,0,0,1,1,1,1,0,1,1,1,0,1,0,0,0,1,1,1,0,0,1,1,1,0,1,1,1,0,1,0,1,1,1,1,1,0,1,1,1,0,1,1,1,1,0,1,0,1,1,0,0,1,0,1,0,0,0,1,1,0,1,0,0,0,1,0,1,1,0,0,1,0,0,1,1,0,1,1,0,0,1,1,0,0,0,1,0,1,0,1,1,1,0,0,0,1,1,0,0,1,0,1,0,1,0,1,0,0,1,0,1,0,0,0,0,1,1,1,0,0,0,0,0,0,0,0,1,1,1,0,0,1,0,0,0,1,1,1,1,1,0,1,0,0,1,0,1,0,1,0,0,0,0,1,1,1,0,0,1,1,1,0,1,1,1,0,0,0,1,0,0,1,1,0,0,1,0,1,1,1,1,0,1,1,0,1,1,1,0,0,0,1,0,1,1,1,1,0,1,0,0,0,0,1,1,1,0,1,1,1,0,1,0,1,0,1,1,1,1,1,1,1,0,0,1]}
        	Test:       	TestMarshalScalar/bw6_761

📦 github.com/consensys/gnark/std/algebra/native/sw_bls24315
❌ TestMarshalScalar 0s

❌ TestMarshalScalar/bw6_633 0s

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 0 == 1
        	            	sw_bls24315.(*MarshalScalarTest).Define
        	            		g1_test.go:47
        	            	
        	            	witness:{"X":{"Limbs":["3326230124356164029","714488970745469180","16417430617600612646","1347093845144562971"]},"R":[0,0,0,1,0,0,1,0,1,0,1,1,0,0,0,1,1,1,0,1,0,1,1,0,1,0,1,1,0,1,1,1,0,0,0,0,0,1,1,0,1,1,1,1,0,1,0,0,1,1,1,0,1,1,0,1,0,0,0,1,1,0,1,1,1,1,1,0,0,0,1,1,1,1,0,1,0,1,1,0,0,1,1,0,1,1,1,0,0,0,1,0,1,0,0,1,1,1,0,1,0,1,1,0,1,0,1,1,0,1,0,0,1,1,0,1,1,0,0,1,0,0,1,0,0,1,1,0,0,0,0,0,1,0,0,1,1,1,1,0,1,0,1,0,0,1,0,1,1,1,1,1,1,1,1,0,1,1,1,0,1,1,1,1,0,0,0,1,0,0,1,1,0,1,1,1,1,1,0,1,1,0,0,0,1,1,1,1,1,1,0,0,0,0,1,0,1,1,1,0,0,0,1,0,1,0,0,1,0,0,1,0,0,1,0,0,1,0,1,0,1,1,0,0,1,1,0,0,1,0,1,1,0,1,1,1,0,0,1,1,1,1,0,1,1,0,0,1,1,0,1,1,1,1,0,1]}
        	Test:       	TestMarshalScalar/bw6_633

📦 github.com/consensys/gnark/std/commitments/kzg
❌ TestKZGVerificationTwoChain 40ms

❌ TestKZGVerificationTwoChain/bw6_761 30ms

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 149836714850269720934438391082781387947376490293086919020861934986775094735624021395194491938548386398108807978600 == 1
        	            	fields_bls12377.(*E2).AssertIsEqual
        	            		e2.go:237
        	            	fields_bls12377.(*E6).AssertIsEqual
        	            		e6.go:299
        	            	fields_bls12377.(*E12).AssertIsEqual
        	            		e12.go:560
        	            	sw_bls12377.(*Pairing).PairingCheck
        	            		pairing2.go:188
        	            	kzg.(*Verifier[...]).AssertProof
        	            		verifier.go:258
        	            	kzg.(*KZGVerificationCircuit[...]).Define
        	            		verifier_test.go:56
        	            	
        	            	witness:schema is inconsistent with Witness
        	Test:       	TestKZGVerificationTwoChain/bw6_761

❌ TestKZGVerificationTwoChain2 60ms

❌ TestKZGVerificationTwoChain2/bw6_633 50ms

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 16120764669520962039785580209459313949512639442102778955259534445742350557226818159690408615334 == 1
        	            	fields_bls24315.(*E2).AssertIsEqual
        	            		e2.go:240
        	            	fields_bls24315.(*E4).AssertIsEqual
        	            		e4.go:249
        	            	fields_bls24315.(*E12).AssertIsEqual
        	            		e12.go:311
        	            	fields_bls24315.(*E24).AssertIsEqual
        	            		e24.go:568
        	            	sw_bls24315.(*Pairing).PairingCheck
        	            		pairing2.go:188
        	            	kzg.(*Verifier[...]).AssertProof
        	            		verifier.go:258
        	            	kzg.(*KZGVerificationCircuit[...]).Define
        	            		verifier_test.go:56
        	            	
        	            	witness:schema is inconsistent with Witness
        	Test:       	TestKZGVerificationTwoChain2/bw6_633

📦 github.com/consensys/gnark/std/recursion
❌ TestHashMarshalScalar 50ms

❌ TestHashMarshalScalar/#01 0s

❌ TestHashMarshalScalar/#01/bw6_761 0s

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 92798767362117070691201253674479572603981331041610282949792077223865605767 == 192073472593785708112435212341387486718018880030771031457955703344491808404
        	            	recursion_test.(*hashMarshalScalarCircuit[...]).Define
        	            		wrapped_hash_test.go:189
        	            	
        	            	witness:{"Scalar":{"Limbs":["15580439985346699239","14830235236036943554","1751756658799062346","51019030540560640"]},"Expected":"192073472593785708112435212341387486718018880030771031457955703344491808404"}
        	Test:       	TestHashMarshalScalar/#01/bw6_761

❌ TestHashMarshalScalar/#02 0s

❌ TestHashMarshalScalar/#02/bw6_633 0s

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 114300419764862296362243810852731803026004052504551754960768658306444735100 == 272362994429422692423226357711259522619865129856146078277062213516732348610
        	            	recursion_test.(*hashMarshalScalarCircuit[...]).Define
        	            		wrapped_hash_test.go:189
        	            	
        	            	witness:{"Scalar":{"Limbs":["9445851164512094335","3919806527670130680","5576857269393096590","566944741996319843"]},"Expected":"272362994429422692423226357711259522619865129856146078277062213516732348610"}
        	Test:       	TestHashMarshalScalar/#02/bw6_633

github-actions · 2023-11-07T12:14:15Z

📦 github.com/consensys/gnark/std/commitments/kzg
❌ TestKZGVerificationTwoChain 60ms

❌ TestKZGVerificationTwoChain/bw6_761 50ms

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 66701263701397516900661102244558881742818505018335197563333744399600335938147016897895048882457339614495484170117 == 1
        	            	fields_bls12377.(*E2).AssertIsEqual
        	            		e2.go:237
        	            	fields_bls12377.(*E6).AssertIsEqual
        	            		e6.go:299
        	            	fields_bls12377.(*E12).AssertIsEqual
        	            		e12.go:560
        	            	sw_bls12377.(*Pairing).PairingCheck
        	            		pairing2.go:195
        	            	kzg.(*Verifier[...]).AssertProof
        	            		verifier.go:258
        	            	kzg.(*KZGVerificationCircuit[...]).Define
        	            		verifier_test.go:56
        	            	
        	            	witness:schema is inconsistent with Witness
        	Test:       	TestKZGVerificationTwoChain/bw6_761

❌ TestKZGVerificationTwoChain2 70ms

❌ TestKZGVerificationTwoChain2/bw6_633 60ms

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 14783592095170323457783773776789255774360161352365297597898680477069399509159689223988124282600 == 1
        	            	fields_bls24315.(*E2).AssertIsEqual
        	            		e2.go:240
        	            	fields_bls24315.(*E4).AssertIsEqual
        	            		e4.go:249
        	            	fields_bls24315.(*E12).AssertIsEqual
        	            		e12.go:311
        	            	fields_bls24315.(*E24).AssertIsEqual
        	            		e24.go:568
        	            	sw_bls24315.(*Pairing).PairingCheck
        	            		pairing2.go:195
        	            	kzg.(*Verifier[...]).AssertProof
        	            		verifier.go:258
        	            	kzg.(*KZGVerificationCircuit[...]).Define
        	            		verifier_test.go:56
        	            	
        	            	witness:schema is inconsistent with Witness
        	Test:       	TestKZGVerificationTwoChain2/bw6_633

github-actions · 2023-11-08T10:53:58Z

📦 github.com/consensys/gnark/std/commitments/kzg
❌ TestKZGVerificationTwoChain 40ms

❌ TestKZGVerificationTwoChain/bw6_761 30ms

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 183668272043299524080062540612391353521035773639581317936544738626651813133565230561682411310631609118189282557511 == 1
        	            	fields_bls12377.(*E2).AssertIsEqual
        	            		e2.go:237
        	            	fields_bls12377.(*E6).AssertIsEqual
        	            		e6.go:299
        	            	fields_bls12377.(*E12).AssertIsEqual
        	            		e12.go:560
        	            	sw_bls12377.(*Pairing).PairingCheck
        	            		pairing2.go:198
        	            	kzg.(*Verifier[...]).AssertProof
        	            		verifier.go:258
        	            	kzg.(*KZGVerificationCircuit[...]).Define
        	            		verifier_test.go:56
        	            	
        	            	witness:schema is inconsistent with Witness
        	Test:       	TestKZGVerificationTwoChain/bw6_761

❌ TestKZGVerificationTwoChain2 90ms

❌ TestKZGVerificationTwoChain2/bw6_633 80ms

    assert.go:200: 
        	Error Trace:	/home/runner/work/gnark/gnark/test/assert.go:200
        	            				/home/runner/work/gnark/gnark/test/assert_checkcircuit.go:50
        	            				/home/runner/work/gnark/gnark/test/assert.go:66
        	Error:      	[assertIsEqual] 38051229909386083520280943873056033020155172487213661803726160403533161395897839145379468534897 == 1
        	            	fields_bls24315.(*E2).AssertIsEqual
        	            		e2.go:240
        	            	fields_bls24315.(*E4).AssertIsEqual
        	            		e4.go:249
        	            	fields_bls24315.(*E12).AssertIsEqual
        	            		e12.go:311
        	            	fields_bls24315.(*E24).AssertIsEqual
        	            		e24.go:568
        	            	sw_bls24315.(*Pairing).PairingCheck
        	            		pairing2.go:198
        	            	kzg.(*Verifier[...]).AssertProof
        	            		verifier.go:258
        	            	kzg.(*KZGVerificationCircuit[...]).Define
        	            		verifier_test.go:56
        	            	
        	            	witness:schema is inconsistent with Witness
        	Test:       	TestKZGVerificationTwoChain2/bw6_633

ivokub added consolidate strengthen an existing feature zk-evm labels Nov 3, 2023

ivokub self-assigned this Nov 3, 2023

ivokub requested a review from ThomasPiellard November 3, 2023 12:57

ivokub added 15 commits November 8, 2023 11:47

feat: newScalar method in 2-chains

484d95b

refactor: better error msgs

3c04ecf

refactor: change curve and pairing definition

9ede837

refactor: 2-chains implement

6f64325

refactor: sw_bls12381 implement

e9e4155

refactor: sw_bn254 implement

facb351

refactor: sw_bw6761 implement

45d4fd1

test: remove unused pairing test

03f7f97

refactor: groth16 implement

082c9a8

refactor: kzg implement

cf4789f

refactor: recursion hash

0634d68

fix: use scalar limb

0c5ecf7

fix: marshal tests with short hash

47e440b

feat: define 2-chain emulation params

1900ec0

feat: use emulated decomposition for scalar marshal

6ec8576

ivokub force-pushed the refactor/scalar-params branch from 6d69ac3 to 6ec8576 Compare November 8, 2023 10:48

feat: repack emulated scalars to frontend.Variable for compatibility

21da748

ivokub mentioned this pull request Nov 8, 2023

feat: batched KZG #908

Merged

ThomasPiellard approved these changes Nov 10, 2023

View reviewed changes

ivokub merged commit 29cadaa into master Nov 10, 2023
7 checks passed

ivokub deleted the refactor/scalar-params branch November 10, 2023 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use emulated.FieldParams as type parameter to generic Curve and Pairing #901

refactor: use emulated.FieldParams as type parameter to generic Curve and Pairing #901

ivokub commented Nov 3, 2023

ivokub commented Nov 6, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 8, 2023

refactor: use emulated.FieldParams as type parameter to generic Curve and Pairing #901

refactor: use emulated.FieldParams as type parameter to generic Curve and Pairing #901

Conversation

ivokub commented Nov 3, 2023

Description

Type of change

How has this been tested?

How has this been benchmarked?

Checklist:

ivokub commented Nov 6, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 8, 2023