Perf/multisymbol 4bw #912
Merged
Perf/multisymbol 4bw #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 ❌ ❌ |
…nark into perf/multisymbol-4bw
|
📦 ❌ ❌ |
|
📦 ❌ ❌ |
|
📦 ❌ ❌ |
|
📦 |
gbotrel
requested changes
Nov 16, 2023
frontend/cs/scs/api.go
Outdated
| @@ -657,6 +702,22 @@ func (builder *builder) Commit(v ...frontend.Variable) (frontend.Variable, error | |||
| }) | |||
| } | |||
|
|
|||
| // NewCombination in the form of res = qL.a + qR.b + qM.ab + qC | |||
| func (builder *builder) NewCombination(a, b frontend.Variable, qL, qR, qM, qC int) frontend.Variable { | |||
There was a problem hiding this comment.
suggestion;
rename to api.EvaluatePlonkExpression + in this function, check that a, b are not constant and do the appropriate path if they are. (else this function will panic).
also add a corresponding interface so that in a circuit, one can check if _, ok := api.(...); ok and have a fail over path for R1CS for example
std/compress/io.go
Outdated
| "os" | ||
| ) | ||
|
|
||
| func GzWrite(outFileName string, o io.WriterTo) error { |
There was a problem hiding this comment.
why do we need to expose that exactly? if you only need it in test, put it iin _test.go files 👍 (but I don't understand from the code why we need it)
There was a problem hiding this comment.
Currently using it for code that outputs the compiled cs, which has to run as a standalone application and not a test.
std/compress/io.go
Outdated
| return a[0] | ||
| } | ||
|
|
||
| func Pack(api frontend.API, words []frontend.Variable, wordLen int) []frontend.Variable { |
…o perf/multisymbol-4bw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements an LZSS based compression scheme and the means to verify its correctness in a SNARK.
Type of change