Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bypass compression #924

Merged
merged 192 commits into from Nov 18, 2023
Merged

Feat/bypass compression #924

merged 192 commits into from Nov 18, 2023

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Nov 17, 2023

Description

Add an option to completely bypass compression to get the upper bound len(compressed) <= 1 + len(uncompressed).

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

TestNoCompressionAttempt

How has this been benchmarked?

Adds about 200K constraints for 600KB of uncompressed data

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tabaie Tabaie requested a review from gbotrel November 17, 2023 19:18
Copy link
Collaborator

@gbotrel gbotrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 just kill api.IsNonZero

frontend/cs/scs/api.go Outdated Show resolved Hide resolved
@Tabaie Tabaie merged commit 9fb591e into master Nov 18, 2023
7 checks passed
@Tabaie Tabaie deleted the feat/bypass-compression branch November 18, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants