more audit corrections and comment emphasis

Consensys · Aug 22, 2023 · 2c71574 · 2c71574
1 parent ac6185e
commit 2c71574
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/contracts/messageService/l1/L1MessageManager.sol b/contracts/messageService/l1/L1MessageManager.sol
@@ -15,8 +15,6 @@ abstract contract L1MessageManager is IL1MessageManager {
   uint8 public constant OUTBOX_STATUS_SENT = 1;
   uint8 public constant OUTBOX_STATUS_RECEIVED = 2;
 
-  /// @dev There is a uint216 worth of storage layout here.
-
   /// @dev Mapping to store L1->L2 message hashes status.
   /// @dev messageHash => messageStatus (0: unknown, 1: sent, 2: received).
   mapping(bytes32 => uint256) public outboxL1L2MessageStatus;

diff --git a/contracts/messageService/lib/Codec.sol b/contracts/messageService/lib/Codec.sol
@@ -11,7 +11,7 @@ library CodecV2 {
    * @notice Decodes a collection of bytes32 (hashes) from the calldata of a transaction.
    * @dev Extracts and decodes skipping the function selector (selector is expected in the input).
    * @dev A check beforehand must be performed to confirm this is the correct type of transaction.
-   * @dev A memory manipulation strips out the function signature, do not reuse.
+   * @dev NB: A memory manipulation strips out the function signature, do not reuse.
    * @param _calldataWithSelector The calldata for the transaction.
    * @return bytes32[] - array of message hashes.
    */

diff --git a/contracts/messageService/lib/TransactionDecoder.sol b/contracts/messageService/lib/TransactionDecoder.sol
@@ -64,7 +64,7 @@ library TransactionDecoder {
   }
 
   /*
-   * @notice Decodes the EIP29230 transaction extracting the calldata.
+   * @notice Decodes the EIP2930 transaction extracting the calldata.
    * @param _transaction The RLP transaction.
    * @return data Returns the transaction calldata as bytes.
    */