fix: fixed M_01 #25
Merged
fix: fixed M_01 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedarkjester
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the tests fail with this modification because the proof has not been updated to the new FS implementation (I tested it locally on test circuits though). I'll ask to regenerate the proof.
Now gamma depends on:
[S_1], [S_2], [S_3], [Ql], [Qr],[Qm],[Qo],[Qk], AND the [Qcp_i], [l], [r], [o], public_inputs
beta depends on gamma
alpha (used to bundle the different arguments) depends on beta AND the commitments to the wires associated to the Qcp_i
zeta depends on alpha and the commitment to the quotient polynomial