Remove java dependency from go tests #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup stage of this private/public state test starts constellation if available on path, or downloads and starts tessera. This adds a dependency on java for the tests to pass. The ubuntu image used by the CI workflow has jdk 1.8 installed hence why this test has been passing. The transaction manager node is not used by the test as it manipulates private state directly, such that no private tx payload read/writes to the tm are made. Removing this section of the test setup removes the java dependency and dramatically decreases the run time of the test (~30secs to 0.1 secs locally) as tessera is no longer downloaded and started.
jpmsam
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup stage of this private/public state test starts constellation if available on path, or downloads and starts tessera.
This adds a dependency on java for the tests to pass. The ubuntu image used by the CI workflow has jdk 1.8 installed by default hence why this test has been passing.
The transaction manager node is not used by the test as it manipulates private state directly, such that no private tx payload read/writes to the tm are made.
Removing this section of the test setup removes the java dependency and dramatically decreases the run time of the test (~50 secs to 0.1 secs locally) as tessera is no longer downloaded and started.