Private contract state extension #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or has been overriden for quorum
currently performed. Move package-wide type and variable definitions into own file for clearer viewing.
to the Raft service. This means we no longer need to wait for it to be provided by the node, and can make the construction of the extension service more synchronous.
bindings. This acts as a mediator between the API code and the generated code, to only expose and simplify the interactions. Move the loading of existing management contracts into constructor instead of initialiser.
transactions for the extension. Remove last direct use of creating a contract instance.
to construct themselves.
manage its own dependencies and make the code more testable.
…orum-geth-upgrade-1.9.7
Update API to show whether a particular node has voted on a contract or not.
…orum-geth-upgrade-1.9.7
…g the contract extension.
…nitiating the contract extension." This reverts commit 75f890d
…s getting extended is the same as value given in privateFor argument in transaction arguments.
# Conflicts: # mkdocs.yml
jpmsam
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a private contract is deployed, it is only available on the nodes where it was initially deployed. Any nodes which are not part of initial contract deployment or new nodes joining the network will not have access to private contract. This PR addresses this issue and allows contract state to be extended to nodes that were not part of original contract deployment.