Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate sub-module for crypto/secp256k1 package #1036

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Create separate sub-module for crypto/secp256k1 package #1036

merged 1 commit into from
Jul 14, 2020

Conversation

chris-j-h
Copy link
Collaborator

Once tagged, this will allow external consumers of the crypto/secp256k1 package to depend only on this package and not the entire quorum codebase

@chris-j-h
Create separate sub-module for crypto/secp256k1 package
73c41e1 
Once tagged, this will allow external consumers of the crypto/secp256k1 package to depend only on this package and not the entire quorum codebase
trung
trung approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@trung trung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpmsam jpmsam merged commit 36cff89 into Consensys:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trung trung trung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris-j-h @trung @jpmsam