Add API for account dump & transaction trace fix #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for public transactions, causing public write operations to abort the trace. Add API method to fetch a straight dump of an account as it exists at a particular block height.
trung
reviewed
Sep 18, 2020
jpmsam
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new API named
debug_dumpAddresshas been added in this PR, which fetches the state of an address at a given block height (includingpendingandlatest). This includes it's code, balance, nonce, storage etc.Note that the storage can get large, so the response can take some time. The request can also take some time due to needing to rebuild the contracts environment if the state isn't present, so if planning on using this API regularly it is recommended to run the node in archive mode.
Also included is a bug fix for tracing transactions. If the transaction is public, a write operation would fail and abort the trace due to the private state being used instead of the public state. The public state is now set correctly in this case.