[raft] fix double addPeer, should also check self. #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking if an enode is already in the raft cluster, the node should also check if it is adding its own enode. This fixes the case where a node can be added twice by running `raft.addPeer(enodeURL)` on itself, e.g. running on a node with the same enodeURL as the node being added. The node will allow the enode to be added again, after which the cluster will be in a weird state containing two peers with the same enodeURL, the duplicate peer will be in a bad state and will not be conneted. Fix by adding a check in `isNodeAlreadyInClusteri(enode)` to check if the enode is the enode of running node, not just one of the peers. In `minter_test.go` the p2p.Server is now mocked out when creating the RaftService, this is necessary as `isNodeAlreadyInCluster` uses the p2p.Server to check if this is the calling node (itself). Mocking out the p2p.Server avoids a 'invalid memory address or nil pointer dereference' exception thrown in the `minter_test.go`.
libby
force-pushed
the
fix-raft-double-add-to-self
branch
from
08e6ccc
to
d194a00
Compare
jpmsam
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if an enode is already in the raft cluster, the node should
also check if it is adding its own enode.
This fixes the case where a node can be added twice by running
raft.addPeer(enodeURL)on itself, e.g. running on a node with the same enodeURL as the node being added.
The node will allow the enode to be added again, after which the cluster will be in a
weird state containing two peers with the same enodeURL, the duplicate peer will
be in a bad state and will not be conneted.
Fix by adding a check in
isNodeAlreadyInClusteri(enode)to check if the enode isthe enode of running node, not just one of the peers.