add raftlogdir commandline option #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prd-fox
suggested changes
Jan 12, 2021
prd-fox
previously approved these changes
Jan 13, 2021
|
Just needs you to run |
prd-fox
previously approved these changes
Jan 15, 2021
|
@melihbirim can you update the PR with the latest master to solve the conflicts? which we could include in the future |
Across Fork PR
Hello, @ricardolyn I resolved the conflicts and updated my branch. Would you please check the PR. Thanks. |
|
@melihbirim some unit tests are failing. also, it needs to be updated with the latest We are still interested in merging this work 👍 |
|
Hi @ricardolyn, we have updated with the latest |
ricardolyn
added
the
doc-change-required
bgravenorst
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Everyone, this PR contains a cli option to externalize raft log dirs.
Command-line option(--raftlogdir) to geth in order to move quorum-raft-state, raft-wal and raft-snap folders due to having large size.
This commit related with #1002