[Fix] core/rawdb: Compare right hash generation for Istanbul when reading from Ancient DB #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Base Geth Ancient DB performs a block header hash check each time it retrieves a block from filesytem. It does so by computing the hash of the raw rlp encoded block stored data.
This leads to an issue when running on IBFT for which block header hash is not equal to the raw rlp encoded block data hash.
To avoid this issue, we parse the data from freezerdb into a Block Header and then we obtain the right hash (which will filter the header for IBFT).
Fixes #1179
Changes