Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure on release pipeline with missing artifact #1185

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fix failure on release pipeline with missing artifact #1185

merged 1 commit into from
Apr 29, 2021

Conversation

ricardolyn
Copy link
Contributor

Changes

  • Use the * to include all files.
  • Fail upload if the file is not there
  • Add a listing to make sure the file is there

achraf17
achraf17 approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@achraf17 achraf17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardolyn ricardolyn merged commit 18b61c2 into Consensys:master Apr 29, 2021
@ricardolyn ricardolyn deleted the fix/release-build branch April 29, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achraf17 achraf17 achraf17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ricardolyn @achraf17