Refactorisation: use a global Quorum Chain Config to avoid mutability #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of save revert reason
config object in the blockchain
remove unused returned nil value
ricardolyn
previously approved these changes
Jul 21, 2021
trung
reviewed
Jul 30, 2021
ricardolyn
approved these changes
Aug 19, 2021
danielporto
pushed a commit
to danielporto/quorum
that referenced
this pull request
Sep 7, 2021
…Consensys#1228) * refactor: pass a quorum config, remove mutability of save revert reason * fix: review: name of config * fix: remove unused params, unit test * task: remove getter * fix: review: multitenant in config, renaming config object in the blockchain * fix: review: renaming quorum config * fix: review: use QuorumChainConfig in eth.Config * fix: review: remove variadic config argument * fix: review: private fields, getters remove unused returned nil value * fix: for review * fix: master merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.