Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mandatory recipients #1243

Merged
merged 9 commits into from
Sep 7, 2021

Conversation

namtruong
Copy link
Contributor

The change is to allow users to add a mandatoryFor parameter when sending a transaction to Quorum. This feature is useful for use cases where there are requirements for regulatory/observing entities that will have access to the full state of a contract.

Changes

  • A new privacy flag called MandatoryRecipients(2). Transactions sent with this enhanced privacy mode will inherit the validations of PartyProtection but not StateValidation. It allows state divergence.
  • A transaction sent with this privacy flag will need to include mandatoryFor : [] - which are private TM public keys - otherwise it will be rejected
  • Members that are part of mandatoryFor will need to be included in the privateFor otherwise transaction will be rejected.
  • /send and /sendsignedtx requests to private TM will include mandatory recipients data
  • mandatoryFor members will also be checked against the contracts that the transaction impact. This is achieved by evm simulation that returns a list of ACOTHs and validations performed in Tessera
  • Corresponding Tessera updates Support for mandatory recipients tessera#1325

Copy link
Contributor

@nicolae-leonte-go nicolae-leonte-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmvalera nmvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Krish1979 Krish1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ricardolyn ricardolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ricardolyn ricardolyn merged commit 38999c7 into Consensys:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants