Upstream merge fixes #1273
Merged
Upstream merge fixes #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
baptiste-b-pegasys
previously approved these changes
Oct 29, 2021
antonydenyer
requested changes
Nov 1, 2021
|
@antonydenyer would you rather getting rid of the upstream cherry-pick and making the bug fix as part of commit a8338d8? |
|
👍 Yeah let's do that for now. |
chris-j-h
dismissed stale reviews from baptiste-b-pegasys and Krish1979
via
1856cae
chris-j-h
force-pushed
the
upstream-merge-fixes
branch
from
a8338d8
to
1856cae
Compare
This is currently only used for the experimental YoloV2 EIP 2929 (where all active precompiles for the current block height must be known) so not critical but worth fixing ahead of the concrete release that will be pulled in from a future upstream geth merge Also includes core/vm: fix Byzantium address list (#22603) (cherry picked from commit 44fe466)
chris-j-h
force-pushed
the
upstream-merge-fixes
branch
from
1856cae
to
6be279d
Compare
antonydenyer
approved these changes
Nov 1, 2021
baptiste-b-pegasys
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes relating to recent upstream geth merges.
ActivePrecompiles()however there is a typo causing tests added in this PR to fail. This bug was fixed in upstream 1.10.2 - the content of that fix has been included in this change. To simplify future merges the content of the commit has been copied instead of cherry-picking the commit.ActivePrecompiles()list. This is currently only used for the experimental YoloV2 EIP 2929 (where all active precompiles for the current block height must be known) so not critical but worth fixing ahead of the concrete release that will be pulled in from a future upstream geth merge.