Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors when there is high load #1302

Merged
merged 6 commits into from
Jan 13, 2022
Merged

Fix errors when there is high load #1302

merged 6 commits into from
Jan 13, 2022

Conversation

baptiste-b-pegasys
Copy link
Contributor

@baptiste-b-pegasys baptiste-b-pegasys commented Jan 12, 2022 •
edited

  • concurrent map modification
  • seg fault

@baptiste-b-pegasys baptiste-b-pegasys self-assigned this Jan 12, 2022
antonydenyer
antonydenyer previously approved these changes Jan 12, 2022
View reviewed changes
@nicolae-leonte-go
Copy link
Contributor

Adding the mutex to StateObject appears to solve the copy problem (which is obviously a good thing).
What I don't understand is why the copy issue only happens for the private state (as the same problem should be reproducible for the public state).
Another concern is also whether we should consider adding the mutex further up (at StateDB level).

nicolae-leonte-go
nicolae-leonte-go approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@nicolae-leonte-go nicolae-leonte-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baptiste-b-pegasys baptiste-b-pegasys enabled auto-merge (squash) January 13, 2022 07:46
@antonydenyer antonydenyer mentioned this pull request Jan 13, 2022
Closed
@baptiste-b-pegasys baptiste-b-pegasys merged commit 5c9f94d into master Jan 13, 2022
@baptiste-b-pegasys baptiste-b-pegasys deleted the fix/highload branch January 13, 2022 08:55
@frankie-lim-partior frankie-lim-partior mentioned this pull request Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonydenyer antonydenyer antonydenyer approved these changes

@nicolae-leonte-go nicolae-leonte-go nicolae-leonte-go approved these changes

Assignees

@baptiste-b-pegasys baptiste-b-pegasys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baptiste-b-pegasys @nicolae-leonte-go @antonydenyer