Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for transitions #1371

Merged
merged 8 commits into from
Apr 6, 2022

Conversation

achraf17
Copy link
Contributor

@achraf17 achraf17 commented Apr 5, 2022

Added support for transitions to switch from IBFT to QBFT dynamically and for other fields like:

  • RequestTimeout
  • Epoch
  • BlockPeriod

@achraf17 achraf17 self-assigned this Apr 5, 2022
antonydenyer
antonydenyer previously approved these changes Apr 5, 2022
Copy link
Contributor

@antonydenyer antonydenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

consensus/istanbul/config.go Show resolved Hide resolved
consensus/istanbul/config.go Show resolved Hide resolved
consensus/istanbul/config.go Show resolved Hide resolved
params/config.go Outdated Show resolved Hide resolved
@achraf17 achraf17 merged commit 551d69b into Consensys:master Apr 6, 2022
@achraf17 achraf17 deleted the feat/transition branch April 6, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants