Maintain P2P connections active during sync #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when getting the Stopped Engine error)
…istanbul_ibft # Conflicts: # eth/handler.go
…debug (such errors occur during node sync since mining is automatically disabled)
baptiste-b-pegasys
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sync is initiated by a node that has fallen behind the rest of the network mining is automatically disabled. With mining disabled the node is unable to process consensus messages sent by the other nodes. When such a message arrives the node gets a
stopped engineerror and the protocol handler returns (it severs the P2P connection).This PR changes the behaviour to ignore
stopped engineerrors if the node is currently syncing (allowing the sync process to progress much swifter without constant interruptions).TODO: A consensus protocol solution would be more appropriate (where the protocol is enhanced to consider only the fully synced peers). In the absence of such a solution, documentation may be useful to state that incoming consensus protocol messages are ignored by a syncing node.