Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logic issue: handlers.removePeer() is called twice (apply bsc856) #1422

Merged
merged 1 commit into from May 30, 2022
Merged

fix logic issue: handlers.removePeer() is called twice (apply bsc856) #1422

merged 1 commit into from May 30, 2022

Conversation

baptiste-b-pegasys
Copy link
Contributor

@baptiste-b-pegasys baptiste-b-pegasys self-assigned this May 27, 2022
achraf17
achraf17 approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@achraf17 achraf17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achraf17 achraf17 merged commit 796a31a into Consensys:master May 30, 2022
@baptiste-b-pegasys baptiste-b-pegasys deleted the fix/peer-remove-called-twice branch September 8, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achraf17 achraf17 achraf17 approved these changes

@antonydenyer antonydenyer Awaiting requested review from antonydenyer

Assignees

@baptiste-b-pegasys baptiste-b-pegasys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: "Ethereum peer removal failed, err=peer not registered" occur quite often.
2 participants
@baptiste-b-pegasys @achraf17