consensus: add Istanbul BFT #166
Conversation
markya0616
force-pushed
the
feature/istanbul
branch
2 times, most recently
from
c6a04d9
to
981ee55
Compare
|
If you could rebase to the latest geth1.6 that would be great. The merge conflicts are very easy. I plan to test using quorum-tools on this branch. |
yutelin
force-pushed
the
feature/istanbul
branch
from
981ee55
to
98200b1
Compare
|
@joelburget done. |
|
This is really great work! Please execute the CLA which is required for merging: https://github.com/jpmorganchase/cla |
yutelin
force-pushed
the
feature/istanbul
branch
from
98200b1
to
4320715
Compare
|
Just done with latest rebasing and sending CLA. @patrickmn |
|
Received--thank you! |
markya0616
force-pushed
the
feature/istanbul
branch
2 times, most recently
from
ee4564e
to
c913474
Compare
| @@ -124,7 +124,7 @@ var ( | |||
| } | |||
| NetworkIdFlag = cli.Uint64Flag{ | |||
| Name: "networkid", | |||
| Usage: "Network identifier (integer, 1=Frontier, 2=Morden (disused), 3=Ropsten, 4=Rinkeby)", | |||
| Usage: "Network identifier (integer, 1=Frontier, 2=Morden (disused), 3=Ropsten, 4=Rinkeby, 5=Ottoman)", | |||
There was a problem hiding this comment.
Seems like we might want to use another (higher) number that's less likely to cause a conflict in the future?
There was a problem hiding this comment.
It depends on the upstream codebase. We submit the same code to geth, so if that gets merged, we are going to grab network id 5. If we eventually get a larger number, I think we can update it here accordingly.
markya0616
force-pushed
the
feature/istanbul
branch
2 times, most recently
from
2df6174
to
7c30f7c
Compare
markya0616
force-pushed
the
feature/istanbul
branch
from
7c30f7c
to
056214e
Compare
|
We've created a PR review guide document. |
joelburget
force-pushed
the
geth1.6
branch
3 times, most recently
from
587ae3b
to
a218568
Compare
…to support custom messages
markya0616
force-pushed
the
feature/istanbul
branch
from
056214e
to
67ca428
Compare
| Protocol() Protocol | ||
| } | ||
|
|
||
| // Handler should be implemented is the consensus needs to handle and send peer's message |
|
Ok to close this? |
|
please help My environment Geth |
|
@AUQIB92 please don't commit on closed issues. Please open a new issue with your problem and one of the team will look into it. |
This PR is the implementation of Istanbul BFT protocol in ethereum/EIPs#650