Fix raft applied index out of range #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzy96
changed the title
zzy96
force-pushed
the
fix-raft-applied-index-out-of-range
branch
from
18acca6
to
8bb47eb
Compare
zzy96
force-pushed
the
fix-raft-applied-index-out-of-range
branch
from
8bb47eb
to
9036022
Compare
jpmsam
reviewed
Nov 29, 2019
jpmsam
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #845
In raft mode,
hard state&entriesare written into WAL before raft entries are processed, butapplied indexis written into the node's local level db only after completion of processing each raft entry. If a node is stopped/ restarted during a large list of entries under processing (particularly when callingapplyRaftSnapshotwhich takes time to sync blocks from peers).hard state&entriesare moving forward butapplied indexis not updated.This fix can successfully recover the node from
applied out of rangepanic state by resettinglast applied indextolast persisted applied indexfrom WAL on raft restart.