Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft.cluster api returns error if no leader is there in the network in version 2.4.0 #934

Merged
merged 11 commits into from
Feb 4, 2020

Conversation

vsmk98
Copy link
Contributor

@vsmk98 vsmk98 commented Feb 1, 2020

In Quorum version 2.4.0, call to raft.cluster returns in error no leader is currently elected if the network is not having a leader node. This is different from behaviour in version where all nodes part of cluster are listed even when the leader is not elected.

This fix addresses the same. The api response has been addressed to include a new attribute nodeActive which will be true if the node is part for raft cluster else will be false. Further if the network is not having a valid leader, the role of each node will be shown as "" . Error handling added for other apis.

#931

jbhurat
jbhurat previously approved these changes Feb 3, 2020
Copy link
Contributor

@jbhurat jbhurat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fixanoid
fixanoid previously approved these changes Feb 3, 2020
jpmsam
jpmsam previously approved these changes Feb 4, 2020
@jbhurat jbhurat dismissed stale reviews from jpmsam, fixanoid, and themself via 2608b97 February 4, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants