Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created special PTM for public-only mode. #968

Merged
merged 10 commits into from
May 12, 2020
Merged

Created special PTM for public-only mode. #968

merged 10 commits into from
May 12, 2020

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Apr 9, 2020

Create subclass of PrivateTransactionManager that returns a not-in-use error on all of the functions. This is used when the node is set to run in public-only mode (PRIVATE_CONFIG=ignore)

error on all of the functions. This is used when the node is set to run
in public-only mode.
@prd-fox prd-fox requested review from trung and zzy96 April 9, 2020 16:19
trung
trung previously approved these changes Apr 14, 2020
Copy link
Contributor

@trung trung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an note that we can use testify/assert package to simplify the assertion logic in tests.

LGTM

@jpmsam jpmsam merged commit 17f98b1 into Consensys:master May 12, 2020
@prd-fox prd-fox deleted the split-not-in-use-txmanager branch May 13, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants