Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle address payable in imports preprocessing parser #256

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

blitz-1306
Copy link
Contributor

Preface

This PR fixes #255.

Changes

  • Handle address payable in file-level definition parser.
  • Introduce related test case.

Notes

  • Credits to @gas1cent and related team for finding and properly reporting the bug.

Regards.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (807be60) 91.18% compared to head (2449847) 91.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files         269      269           
  Lines        6481     6481           
  Branches     1313     1313           
=======================================
  Hits         5910     5910           
  Misses        464      464           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cd1m0 cd1m0 merged commit 0b42401 into master Feb 16, 2024
3 checks passed
@cd1m0 cd1m0 deleted the fix-255 branch February 16, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declaring a top-level payable constant results in CompileInferenceError
3 participants