Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid OpenAPI spec output from swagger-ui #3209

Closed
Magicking opened this issue Nov 13, 2020 · 1 comment · Fixed by #3212
Closed

Invalid OpenAPI spec output from swagger-ui #3209

Magicking opened this issue Nov 13, 2020 · 1 comment · Fixed by #3212
Assignees
@rolfyone

Comments

@Magicking
Copy link

Description

The output JSON specification is invalid because of an extra exampleSetFlag element.
Possible duplicate of swagger-api/swagger-core#3702 with explanation at swagger-api/swagger-core#3637 (comment)

Steps to Reproduce (Bug)

%> openapi-generator validate -i https://consensys.github.io/teku/latest.json
Validating spec (https://consensys.github.io/teku/latest.json)               
Errors:
	- attribute
	  paths.'/eth/v1/beacon/states/{state_id}/committees'(get).parameters.[slot].schemas.exampleSetFlag
	  is unexpected
	- attribute paths.'/eth/v1/events'(get).parameters.[topics].schemas.exampleSetFlag is
	  unexpected
[...]

[error] Spec has 108 errors.

Expected behavior: [What you expect to happen]

The specification validate.

Actual behavior: [What actually happens]

The specification doesn't validate.

Frequency: [What percentage of the time does it occur?]

Versions (Add all that apply)

  • Software version: d6e1ff9 (latest)
@rolfyone
Copy link
Contributor

swagger-docs started generating this field after an update. I have looked into it briefly, but I'll take another look and see if i can find a decent solution to the problem...

@rolfyone rolfyone self-assigned this Nov 13, 2020
rolfyone added a commit to rolfyone/teku that referenced this issue Nov 13, 2020
@rolfyone
Remove exampleSetFlag from swagger-docs
e6fd28c 
 - Seems to have been introduced with swagger-core:2.1.4 changes. Downgraded to 2.1.3, as 2.1.5 didn't seem to help.

 - updated javalin to 3.11.2, but it didn't actually help. I'll leave it at the newer point release.

 fixes Consensys#3209

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@rolfyone rolfyone mentioned this issue Nov 13, 2020
Merged
1 task
rolfyone added a commit that referenced this issue Nov 13, 2020
@rolfyone
Remove exampleSetFlag from swagger-docs (#3212)
fe55d35 
- Seems to have been introduced with swagger-core:2.1.4 changes. Downgraded to 2.1.3, as 2.1.5 didn't seem to help.

 - updated javalin to 3.11.2, but it didn't actually help. I'll leave it at the newer point release.

 fixes #3209

Signed-off-by: Paul Harris <paul.harris@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolfyone rolfyone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove exampleSetFlag from swagger-docs rolfyone/teku
2 participants
@Magicking @rolfyone