Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bounds checking in verify_bitfield - (Spec PR #573) #395

Closed
schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Closed

Fix bounds checking in verify_bitfield - (Spec PR #573) #395

schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Labels
enhancement 🕵️‍♀️ New feature or request
Milestone
Beacon Chain v0.4...

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want the bounds checking in verify_bitfield to work so that Artemis has proper bounds checking and is compliant with the Beacon Chain spec.

Acceptance Criteria

  • verify_bitifield in BeaconStateUtil should take into account the size of the bitfield when performing get_bitfield_bit to avoid an index out of bounds error. (See referenced PR.)
  • Adequate testing is performed on change.

Additional Information
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Feb 26, 2019
@vitorpy vitorpy mentioned this issue Feb 27, 2019
Merged
@schroedingerscode schroedingerscode added in progress 🚧 This issue or pull request is in progress and removed in progress 🚧 This issue or pull request is in progress labels Feb 27, 2019
@schroedingerscode
Copy link
Contributor Author

Closed by #405

@schroedingerscode schroedingerscode removed the in progress 🚧 This issue or pull request is in progress label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
1 participant
@schroedingerscode