Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bounds checking in verify_bitfield - (Spec PR #573) #405

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Fix bounds checking in verify_bitfield - (Spec PR #573) #405

merged 2 commits into from
Feb 27, 2019

Conversation

vitorpy
Copy link
Contributor

@vitorpy vitorpy commented Feb 27, 2019

PR Description

Fix bounds checking in verify_bitfield - (Spec PR #573)

Waiting for 0.2 branch

Fixed Issue(s)

Fixes #395

@schroedingerscode schroedingerscode changed the base branch from master to v0.4-integration February 27, 2019 21:44
@schroedingerscode schroedingerscode changed the title [WIP] Fix bounds checking in verify_bitfield - (Spec PR #573) Fix bounds checking in verify_bitfield - (Spec PR #573) Feb 27, 2019
schroedingerscode
schroedingerscode approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@schroedingerscode schroedingerscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks great. It bugs me we didn't implement variable length bitfields initially, but that's next. 😄

@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Feb 27, 2019
@schroedingerscode schroedingerscode self-assigned this Feb 27, 2019
@schroedingerscode schroedingerscode merged commit a8d610e into Consensys:v0.4-integration Feb 27, 2019
@schroedingerscode schroedingerscode mentioned this pull request Feb 27, 2019
Closed
@vitorpy vitorpy deleted the verify_bitfield branch February 27, 2019 22:59
jrhea pushed a commit to jrhea/artemis that referenced this pull request Mar 1, 2019
@vitorpy @jrhea
Fix bounds checking in verify_bitfield - (Spec PR Consensys#573) (Con…
db51ad1 
…sensys#405)
@schroedingerscode schroedingerscode removed this from the Beacon Chain v0.4.0 Spec milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schroedingerscode schroedingerscode schroedingerscode approved these changes

Assignees

@schroedingerscode schroedingerscode

Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vitorpy @schroedingerscode