Use increment not replace when calculating rewards #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
commented
May 1, 2020
| @@ -355,9 +354,9 @@ private static UnsignedLong get_base_reward(BeaconState state, int index) { | |||
| UnsignedLong increment = EFFECTIVE_BALANCE_INCREMENT; | |||
| final UnsignedLong reward_numerator = | |||
| index_base_reward.getValue().times(attesting_balance.dividedBy(increment)); | |||
| rewards.set(index, reward_numerator.dividedBy(total_balance.dividedBy(increment))); | |||
There was a problem hiding this comment.
Apparently the spec had this same bug: https://github.com/ethereum/eth2.0-specs/pull/1680/files
cemozerr
reviewed
May 1, 2020
|
Apparently we don't have a reference test that goes round that loop twice for the same validator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes a consensus failure on the Schlesi testnet block 64.
get_attestation_deltaswas replacing the value for rewards instead of incrementing it. As a result the total reward allocated was half what it should have been.