Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce length bounds for Req/Resp messages #2360

Merged
merged 5 commits into from
Jul 16, 2020

Conversation

ajsutton
Copy link
Contributor

PR Description

Immediately rejects requests or responses which have a length prefix outside the range of possible valid lengths for the data type.

Fixed Issue(s)

fixes #2077

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

@ajsutton ajsutton marked this pull request as ready for review July 16, 2020 02:17
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton merged commit 04b0a00 into Consensys:master Jul 16, 2020
@ajsutton ajsutton deleted the enforce-lengths branch July 16, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update p2p reqresp with explicit handling of reqresp size bounds
2 participants