re-enable forkchoice/on_block and disabling only non working tests
#4447
Conversation
tbenr
changed the title
forkchoice/onblock and disabling only new_finalized_slot_is_justified_checkpoint_ancestorforkchoice/onblock and disabling only non working tests
tbenr
changed the title
forkchoice/onblock and disabling only non working testsforkchoice/on_block and disabling only non working tests
...referenceTest/java/tech/pegasys/teku/reference/phase0/forkchoice/ForkChoiceTestExecutor.java
Outdated
Show resolved
Hide resolved
added "new_justified_is_later_than_store_justified" in the "fork_choice/on_block" exclusion list
tbenr
force-pushed
the
skip_only_specific_fork_choiche_tests
branch
from
ecaffdf
to
9123470
Compare
| "fork_choice/on_block", | ||
| new ForkChoiceTestExecutor( | ||
| "new_finalized_slot_is_justified_checkpoint_ancestor", | ||
| "new_justified_is_later_than_store_justified")) |
There was a problem hiding this comment.
Hey @ajsutton @tbenr
I think new_justified_is_later_than_store_justified was fixed in ethereum/consensus-specs#2577
Do you mind checking again?
There was a problem hiding this comment.
@hwwhww still not working. I run against freshly downloaded 1.1.3, is it correct?
There was a problem hiding this comment.
The fix was included since v1.1.0-beta.4. I think @ajsutton once verified Teku works with my tarball files locally in September?
There was a problem hiding this comment.
@hwwhww the weird thing is that when I run that locally it works. Not yet figured out whats going on in CI...
There was a problem hiding this comment.
So locally I see new_finalized_slot_is_justified_checkpoint_ancestor failing but my understanding is it winds up triggering the same condition as new_justified_is_later_than_store_justified where the newly imported block is not considered the head even though it just caused the update in justification/finalization.
So I think the tests are right and Teku is incorrect in both cases. Though I think Teku's result actually makes far more sense than the spec result.
PR Description
re-enable
fork_choice/on_blockreference test types.Introducing per test exclusion.
ForkChoiceTestExecutorinstance forfork_choice/on_blockhas been configured to skip:new_finalized_slot_is_justified_checkpoint_ancestornew_justified_is_later_than_store_justifiedDocumentation
documentationlabel to this PR if updates are required.Changelog