Ignore aggregate attestations that are a subset of aggregates we've already seen #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Change the aggregate attestation validation rules to ignore any aggregate that we've seen a non-strict superset for already. This avoids reprocessing and gossiping aggregates that add no new value.
The set of received aggregate hashes is removed because they will be caught by this new check (ie an aggregate is always a non-strict superset of itself).
Fixed Issue(s)
#5304 (need to apply to sync committee aggregates as well before it's complete)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog