Ignore sync committee contributions that are a subset of ones we've already seen #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
May 6, 2022
Comment on lines
+40
to
+41
| public static final int VALID_CONTRIBUTION_AND_PROOF_SET_SIZE = 512; | ||
| public static final int VALID_SYNC_COMMITTEE_MESSAGE_SET_SIZE = 512; |
There was a problem hiding this comment.
if it still breaks, maybe increase this to be large enough for 2 slots.. i have vague memories...
There was a problem hiding this comment.
It should be all good now. Having that too low would make it more likely to pass as we'd process more messages than we need to. But for sync committee messages I'm pretty confident there's no need to keep two slots since we ignore anything not from the current slot anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Sync sync contribution validation rules to ignore any contribution that we've seen a non-strict superset for already.
Also reduced the cache size for sync committee gossip. There are only 512 members of the sync committee and we automatically ignore messages that aren't for the current slot so at most we need to remember 512 seen messages.
Fixed Issue(s)
fixes #5304
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog