Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mev Boost\Builder] implement builder registration call in ProposersDataManager #5535

Merged
merged 6 commits into from
May 19, 2022

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented May 19, 2022

Implements the backend of the beacon rest api register_validator endpoint (ref: ethereum/beacon-APIs#209)

since on the builder side the corresponding api do not accept array, this PR calls the builder api in sequence, one by one, stopping in case of networking issues or Timeout on SafeFuture. The reason is to avoid congesting the throttled rest client and delaying potential block building calls.

related to #5396

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit 6819478 into Consensys:master May 19, 2022
@tbenr tbenr deleted the call_builder_registervalidators branch May 19, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants