Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kzg computing proof segfault and update trusted setup #6603

Merged
merged 5 commits into from Dec 14, 2022
Merged

Fix kzg computing proof segfault and update trusted setup #6603

merged 5 commits into from Dec 14, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Dec 14, 2022 •
edited

PR Description

  • Updated trusted setup with one from the specs
  • Added testComputingProofWithZeroLengthBlobs test. It was failing with segfault before the change and it was working after the change)
  • Removed verifyKzgProof (only used in EL)

Fixed Issue(s)

helps with #6596

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

tbenr
tbenr approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit b3c20dd into Consensys:master Dec 14, 2022
@StefanBratanov StefanBratanov deleted the fixes_kzg branch December 14, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StefanBratanov @tbenr