Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blockValue to get payload V2 response #6614

Merged
merged 6 commits into from
Dec 16, 2022

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Dec 15, 2022

PR Description

Update expected response from get payload V2 to include the block value as per ethereum/execution-apis#314

Note that the value isn't currently used anywhere - just updated so that we can handle the new format.

To smooth the transition for any existing testnets, the old version without block value is supported by specifying --Xee-version=NO_BLOCK_VALUE.

Fixed Issue(s)

#6612

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton enabled auto-merge (squash) December 16, 2022 21:17
@ajsutton ajsutton merged commit d099be7 into Consensys:master Dec 16, 2022
@ajsutton ajsutton deleted the local-block-value branch December 16, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants