subnets subscription revamp #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
force-pushed
the
7296-subnet-subscriptions
branch
from
b050182
to
e0757bd
Compare
mehdi-aouadi
force-pushed
the
7296-subnet-subscriptions
branch
2 times, most recently
from
8322063
to
23e12f4
Compare
zilm13
reviewed
Jul 7, 2023
ethereum/spec/src/main/java/tech/pegasys/teku/spec/constants/ValidatorConstants.java
Outdated
Show resolved
Hide resolved
...a/tech/pegasys/teku/networking/eth2/gossip/subnets/ValidatorBasedStableSubnetSubscriber.java
Outdated
Show resolved
Hide resolved
...a/tech/pegasys/teku/networking/eth2/gossip/subnets/ValidatorBasedStableSubnetSubscriber.java
Outdated
Show resolved
Hide resolved
mehdi-aouadi
changed the title
mehdi-aouadi
changed the title
mehdi-aouadi
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...n/java/tech/pegasys/teku/networking/eth2/gossip/subnets/NodeBasedStableSubnetSubscriber.java
Fixed
Show resolved
Hide resolved
mehdi-aouadi
force-pushed
the
7296-subnet-subscriptions
branch
from
273afe7
to
8bb1462
Compare
tbenr
reviewed
Jul 12, 2023
ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/common/helpers/MiscHelpers.java
Outdated
Show resolved
Hide resolved
tbenr
reviewed
Jul 12, 2023
.../beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/BeaconChainController.java
Show resolved
Hide resolved
mehdi-aouadi
force-pushed
the
7296-subnet-subscriptions
branch
2 times, most recently
from
93ea71a
to
b500a6c
Compare
mehdi-aouadi
added
the
doc-change-required
zilm13
approved these changes
Jul 31, 2023
ethereum/spec/src/test/java/tech/pegasys/teku/spec/logic/common/helpers/MiscHelpersTest.java
Outdated
Show resolved
Hide resolved
...c/main/java/tech/pegasys/teku/networking/eth2/gossip/subnets/AttestationTopicSubscriber.java
Outdated
Show resolved
Hide resolved
2 tasks
mehdi-aouadi
removed
the
doc-change-required
mehdi-aouadi
added
the
doc-change-required
alexandratran
removed
the
doc-change-required
|
Just adding a reference to the spec pr: ethereum/consensus-specs#3312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Subscribe to fixed
SUBNETS_PER_NODEattestation subnets based on the node id forEPOCHS_PER_SUBNET_SUBSCRIPTIONepochs:compute_subscribed_subnets(node_id, epoch)function--Xp2p-minimum-subnet-subscriptionscli option added in Create CLI option for minimum persistent attestation subnet subscriptions #6580The spec can be found here
Fixed Issue(s)
fixes #7296
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog