Configure Deneb on Goerli #7857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -71,6 +74,8 @@ EJECTION_BALANCE: 16000000000 | |||
| MIN_PER_EPOCH_CHURN_LIMIT: 4 | |||
| # 2**16 (= 65,536) | |||
| CHURN_LIMIT_QUOTIENT: 65536 | |||
| # [New in Deneb:EIP7514] 2**3 (= 8) | |||
| MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT: 8 | |||
|
|
|||
|
|
|||
| # Fork choice | |||
There was a problem hiding this comment.
Are we missing updating PROPOSER_SCORE_BOOST to 40?
There was a problem hiding this comment.
Yeah, think so. Changed it. But this is not DENEB specific, so it's weird it hasn't been changed.
StefanBratanov
force-pushed
the
deneb-goerli
branch
from
ca7afd3
to
30681ca
Compare
tbenr
reviewed
Jan 8, 2024
Comment on lines
138
to
139
| MAX_BLOBS_PER_BLOCK: 6 |
There was a problem hiding this comment.
shouldn't be inherited from mainnet preset and not be specified here?
There was a problem hiding this comment.
(as per merged config in https://github.com/eth-clients/goerli/pull/178/files)
There was a problem hiding this comment.
very good catch, fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Configuring Deneb on Goerli as per: eth-clients/goerli#178
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog