Allow voluntary exit command to write to file rather than publish #8168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The advantage of this is that the message can avoid epoch validation, and also it can separate the submission of the exit from creation, so if something fails, it can have further investigation. The format saved to json will allow it to be posted directly to the voluntary exits beacon-api POST endpoint. Assists with Consensys#8158 but only as a potential workaround, allowing us to avoid setting up the keymanager-api to generate an exit. Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
rolfyone
added a commit
to rolfyone/doc.teku
that referenced
this pull request
Apr 4, 2024
Documented the flag added in Consensys/teku#8168
tbenr
approved these changes
Apr 4, 2024
teku/src/main/java/tech/pegasys/teku/cli/subcommand/VoluntaryExitCommand.java
Outdated
Show resolved
Hide resolved
teku/src/main/java/tech/pegasys/teku/cli/subcommand/VoluntaryExitCommand.java
Outdated
Show resolved
Hide resolved
teku/src/main/java/tech/pegasys/teku/cli/subcommand/VoluntaryExitCommand.java
Show resolved
Hide resolved
lucassaldanha
approved these changes
Apr 4, 2024
Signed-off-by: Paul Harris <paul.harris@consensys.net>
alexandratran
added a commit
to Consensys/doc.teku
that referenced
this pull request
Apr 5, 2024
* Documented the save-exits-path for Voluntary exit Documented the flag added in Consensys/teku#8168 * edits for clarity --------- Co-authored-by: Alexandra Tran <alexandratran@protonmail.com> Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantage of this is that the message can avoid epoch validation, and also it can separate the submission of the exit from creation, so if something fails, it can have further investigation.
The format saved to json will allow it to be posted directly to the voluntary exits beacon-api POST endpoint.
Assists with #8158 but only as a potential workaround, allowing us to avoid setting up the keymanager-api to generate an exit.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog