Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EIP-7549] Add committees size map to ValidatableAttestation #8301

Merged
merged 2 commits into from
May 8, 2024
Merged

[EIP-7549] Add committees size map to ValidatableAttestation #8301

merged 2 commits into from
May 8, 2024

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 8, 2024 •
edited
Loading

PR Description

  • Add committeesSize map to ValidatableAttestation to be used later in aggregation.
  • Also changed EpochCachePrimer to use spec.getBeaconCommitteesSize in order to cache both the sizes and the committees

Fixed Issue(s)

Related to #7965

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov marked this pull request as ready for review May 8, 2024 16:20
tbenr
tbenr approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 4b4bd47 into Consensys:master May 8, 2024
16 checks passed
@StefanBratanov StefanBratanov deleted the add_committees_size branch May 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StefanBratanov @tbenr