Provide committeesSize to MatchingDataAttestationGroup #8304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public MatchingDataAttestationGroup( | ||
| final Spec spec, | ||
| final AttestationData attestationData, | ||
| @SuppressWarnings("unused") final Supplier<Int2IntMap> commiteesSizeSupplier) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
rolfyone
reviewed
May 9, 2024
| recentChainData | ||
| .retrieveStateAtSlot(slotAndBlockRoot) | ||
| // the attestation pool flow is entirely synchronous so joining here | ||
| .join() |
|
merged via #8305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
committeesSizeis required for EIP-7549 aggregations when adding attestations coming from an imported block to track the attestations which are already onchain, so adding a way to retrieve it using the statecommitteesSizeis not present in aValidatableAttestation, so having a fallback to the state ensures we don't fail.Fixed Issue(s)
related to #7965
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog