Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to whitelist filter #1036

Merged
merged 6 commits into from
Apr 20, 2020
Merged

Fixes to whitelist filter #1036

merged 6 commits into from
Apr 20, 2020

Conversation

SatpalSandhu61
Copy link
Contributor

  • Fixing whitelist validation for curl requests (where local host IP is IPv6 format).
  • Adding extra log info when peer rejected due to whitelist.
  • Remove catch for generic exception, where whitelist was being disabled.

@SatpalSandhu61
Fixing whitelist validation for curl requests.
bca2cb9 
Adding details of a host which fails whitelist.
@SatpalSandhu61
Remove catch of generic exception, where whitelist validation was bei…
9ff494d 
…ng disabled (could be a security concern).
prd-fox
prd-fox previously approved these changes Apr 20, 2020
View reviewed changes
@Krish1979 Krish1979 merged commit c0ab2f3 into master Apr 20, 2020
@SatpalSandhu61 SatpalSandhu61 deleted the fixes_to_whitelist_filter branch April 23, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-j-h chris-j-h chris-j-h approved these changes

@nicolae-leonte-go nicolae-leonte-go nicolae-leonte-go approved these changes

@prd-fox prd-fox prd-fox left review comments

@melowe melowe Awaiting requested review from melowe

@namtruong namtruong Awaiting requested review from namtruong namtruong is a code owner

Assignees
No one assigned
Labels
0.10.5 cleanup tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SatpalSandhu61 @prd-fox @chris-j-h @nicolae-leonte-go @Krish1979